Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions - Revise prose for status check #22638

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

totten
Copy link
Member

@totten totten commented Jan 27, 2022

Overview

This is a follow-up to revise the prose introduced by #22464 (merged on the same 5.47.alpha1).

cc @colemanw @demeritcowboy

Before

Example with one missing dependency - which is available but not active. (This PR addresses the message in the middle; other messages are shown for context.)

Extension Errors - Before - 1x

Example with two missing dependencies - one available-inactive and one totally unknown:

Extension Errors - Before - 2x

Notes:

  • Text containing the extension labels and keys is non-distinct. Assumes "label" is title-case.
  • Uses <ul> without any intro text, so it it looks different from other messages.
  • The title is singular ("Error") but may list multiple errors.

After

Example with one missing dependency - which is available but not active. (This PR addresses the message in the middle; other messages are shown for context.)

Extension Errors - After - 1x

Example with two missing dependencies - one available-inactive and one totally unknown:

Extension Errors - After - 2x

@civibot
Copy link

civibot bot commented Jan 27, 2022

(Standard links)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants