Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable code #22594

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Remove unreachable code
Most of the code in this newly separated function is unreachable...

Before

We are only passing in 2 params

  • email
  • location_type_id

image

So all sections that look for another param are unreachable.
In addtion the contact store values routine does not add anything to $values only $params - see #22593

So all sections that expect anything else n $values are unreachable. In addition the if (!empty($values['location_type_id'])) { has a return in it - so anything after that function is unreachable too....

image

image

After

poof

Technical Details

@colemanw so we can see most of the code only existed for the other function....

Comments

@civibot
Copy link

civibot bot commented Jan 21, 2022

(Standard links)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants