Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unreachable code
Most of the code in this newly separated function is unreachable...
Before
We are only passing in 2 params
So all sections that look for another param are unreachable.
In addtion the contact store values routine does not add anything to
$values
only$params
- see #22593So all sections that expect anything else n
$values
are unreachable. In addition theif (!empty($values['location_type_id'])) {
has a return in it - so anything after that function is unreachable too....After
poof
Technical Details
@colemanw so we can see most of the code only existed for the other function....
Comments