Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate function from deprecated utils onto calling classes & remove #22481

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Duplicate function from deprecated utils onto calling classes & remove

Before

Less more

After

OMG more nasty code - but it is easier to deal with

Technical Details

Comments

@civibot civibot bot added the master label Jan 12, 2022
@civibot
Copy link

civibot bot commented Jan 12, 2022

(Standard links)

@colemanw
Copy link
Member

colemanw commented Jan 21, 2022

Yikes 😱 it feels really uncomfortable to merge this and turn that into a two-headed beast. Once divided, do you have plans to conquer?
I think those functions need a @deprecated annotation at least.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw I can easily remove almost all of it from the mail format place - the other class is already overrun with functions called deprecated this & deprecated that so it's pretty implicit! Most of it isn't required for either place (althtough I'm a bit wary of adding in more cleanup PRs until I get my existing ones merged I'd do the forward one straight away)

@colemanw colemanw merged commit 01f1b06 into civicrm:master Jan 21, 2022
@colemanw colemanw deleted the deprecated branch January 21, 2022 02:30
@eileenmcnaughton
Copy link
Contributor Author

#22594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants