Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix Pledge Test failing on php8 by ensuring all payments have a… #22037

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

seamuslee001
Copy link
Contributor

… status assigned and that customGroup is always assigned to the template and updating test to pass in some additional form values

Overview

This fixes the currently failing CRM_Pledge_Form_PledgeTest on php8 by ensuring that all payments even pending ones have a status in the array assigned and also by ensuring customGroup variable is always assigned to the template and fixing the form object in the test

Before

Test fails on php8

After

Test passes on php8

ping @demeritcowboy @eileenmcnaughton

@civibot
Copy link

civibot bot commented Nov 11, 2021

(Standard links)

… status assigned and that customGroup is always assigned to the template and updating test to pass in some additional form values
@seamuslee001 seamuslee001 merged commit 06cc0f4 into civicrm:master Nov 11, 2021
@seamuslee001 seamuslee001 deleted the ref_pledge_test_php8 branch November 11, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants