Merge pull request #22037 from seamuslee001/ref_pledge_test_php8

[REF] Fix Pledge Test failing on php8 by ensuring all payments have a…

CRM/Pledge/BAO/Pledge.php

@@ -534,6 +534,7 @@ public static function sendAcknowledgment(&$form, $params) {
           [
             'amount' => $values['scheduled_amount'] ?? NULL,
             'due_date' => $values['scheduled_date'] ?? NULL,
+            'status' => CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Pending'),
           ]
         );
 
@@ -570,10 +571,10 @@ public static function sendAcknowledgment(&$form, $params) {
     }
 
     // handle custom data.
+    $customGroup = [];
     if (!empty($params['hidden_custom'])) {
       $groupTree = CRM_Core_BAO_CustomGroup::getTree('Pledge', NULL, $params['id']);
       $pledgeParams = [['pledge_id', '=', $params['id'], 0, 0]];
-      $customGroup = [];
       // retrieve custom data
       foreach ($groupTree as $groupID => $group) {
         $customFields = $customValues = [];
@@ -590,8 +591,8 @@ public static function sendAcknowledgment(&$form, $params) {
         $customGroup[$group['title']] = $customValues;
       }
 
-      $form->assign('customGroup', $customGroup);
     }
+    $form->assign('customGroup', $customGroup);
 
     // handle acknowledgment email stuff.
     [$pledgerDisplayName, $pledgerEmail] = CRM_Contact_BAO_Contact_Location::getEmailDetails($params['contact_id']);

tests/phpunit/CRM/Pledge/Form/PledgeTest.php

@@ -31,6 +31,13 @@ public function testPostProcess(): void {
       'from_email_address' => Email::get()
         ->addWhere('contact_id', '=', $loggedInUser)
         ->addSelect('id')->execute()->first()['id'],
+      'frequency_interval' => 1,
+      'frequency_unit' => 'month',
+      'installments' => 5,
+      'currency' => 'USD',
+      'scheduled_amount' => 10,
+      'frequency_day' => 4,
+      'status' => 'Pending',
     ]);
     $form->buildForm();
     $form->postProcess();