Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email tokens - preparatory sanity imposition #21741

Closed

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Move crazy submit pre-processing out of buildForm

Before

Pre-processing of submitted values begins in buildForm making it mind-breakingly hard to figure out what is happening

After

Moved to getting the details from the submitted value in the to field

Technical Details

@demeritcowboy - still working through testing this & trying to build off it - but I think this is the missing piece for taking the email trait out of the twilight zone & into the 'merely laddened with technical debt' zone

I might need to add some filtering to 'submit' to remove 'should not email' types

Comments

Depends on #21676

@civibot
Copy link

civibot bot commented Oct 6, 2021

(Standard links)

@civibot civibot bot added the master label Oct 6, 2021
@eileenmcnaughton eileenmcnaughton changed the title Email tokens Email tokens - preparatory sanity imposition Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant