Email tokens - preparatory sanity imposition #21741
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move crazy submit pre-processing out of buildForm
Before
Pre-processing of submitted values begins in
buildForm
making it mind-breakingly hard to figure out what is happeningAfter
Moved to getting the details from the submitted value in the
to
fieldTechnical Details
@demeritcowboy - still working through testing this & trying to build off it - but I think this is the missing piece for taking the email trait out of the twilight zone & into the 'merely laddened with technical debt' zone
I might need to add some filtering to 'submit' to remove 'should not email' types
Comments
Depends on #21676