dev/core#2866 Ignore preferred mail format - send to both

[eileenmcnaughton]

Overview

dev/core#2866 Ignore preferred mail format - send to both

This was canvassed in gitlab (thumbs up from @aydun) and on github where @jmcclelland @colemanw and @JoeMurray spoke in support - no counter views.

Before

From email task the user's preferred_mail_format is dependent on the user's value for the field

After

We live in a world where users have mail clients that receive 'both' and present to them based on their settings. Also civicrm has moved out of cvs through svn to github since it seemed like a good idea

Technical Details

It only affects the email task for now because I think to remove from other places I'd need to remove it from the UI too but in terms of the email task it's adding complexity that I kinda need to remove in order to resolve other issues around loading rows

Comments

Also - I suspect this might be broken :-)

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Totally agree, and I still would like to see that setting completely removed.

[eileenmcnaughton]

@colemanw I need this to be merged before the rc if I'm gonna have a hope of getting extra token support in this class - see #21745

[colemanw]

Well, it went out as a proposal in the dev digest and no one is pushing back.
I also don't remember any complaints when we dropped support for Internet Explorer 6.