[REF] Update Frequenecy template assignments in UpdateBilling to be c…

[seamuslee001]

…onsistent with #21469

Overview

Title says it all

Before

2 different variable names across 2 different recur forms that assign the same thing

After

1 set of variable names across both forms

ping @jaapjansma @mattwire

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 in fact we don't need to - once we add a workflow message template for the tpl like #21611 we will remove those assigns.

In the template the goal is to swap to using real tokens - ie {contribution_recur.installments} but there is a mechanism to provide for the prior values to be assigned during transition

https://github.com/civicrm/civicrm-core/pull/21611/files#diff-17772958e7f00fb5d7b62b483757e8df3eb5edd71bdaa7c579534863c805d390R23-R25

Note that I did have update billing next on my list of templates to tackle adding a workflow template for - it's pending a few things

• merge on Add workflow template for recurring cancelled #21611
• figuring out a better way of dealing with address tokens - which will follow on from [REF] Separate contact tokens from 'tokenCompatSubscriber' #21626
• merge on Simplify getRecurFromAddress #21613

The specific challenge on addresses is that we ideally want to render {contact.address_billing.street_address} - I have some thoughts

[eileenmcnaughton]

Oh - I guess it's the form template not the message template