Add workflow template for recurring cancelled #21611
Conversation
|
(Standard links)
|
3f739a7 to
c9bba50
Compare
c9bba50 to
5138679
Compare
|
test this please |
5138679 to
8e6d67a
Compare
|
test this please |
| protected function exportExtraTokenContext(array &$export): void { | ||
| $export['smartyTokenAlias']['installments'] = 'contribution_recur.installments'; | ||
| $export['smartyTokenAlias']['amount'] = 'contribution_recur.amount'; | ||
| $export['smartyTokenAlias']['recur_frequency_unit'] = 'contribution_recur.frequency_unit'; | ||
| $export['smartyTokenAlias']['recur_frequency_unit'] = 'contribution_recur.frequency_unit:label'; |
There was a problem hiding this comment.
@totten I think without this change ^^ we will have a regression in 5.43 around translation of 'year' - I saw it on one of your screenshots
68b19c6 to
17dcefd
Compare
17dcefd to
89ec98b
Compare
|
@colemanw @seamuslee001 @demeritcowboy any of you OK to merge this? I'd like to add a trait for the contribution ones (already have for participant) & maybe membership so tokens for the base entity are available |
9ac6155 to
00d5eac
Compare
00d5eac to
d38723e
Compare
This is a simple template, with a slightly smaller subset of values than the exisiting one. It pulls out the recurring part to a trait...
d38723e to
e589a77
Compare
|
@seamuslee001 @colemanw @demeritcowboy is this one one of you could look at? It doesn't have the 'has-test' label because I got the tests merged prior to this PR but the change is covered by a unit test. |
|
I've taken a little look it's just an area I rarely deal with. Codewise it looks ok but I'd want to run it which I can try. It looks like this is supporting two templates, for memberships and contributions. |
|
I agree with @demeritcowboy on the code structure and we have a decent amount of tests that cover this so I am ok to merge on that basis |
|
thanks @seamuslee001 @demeritcowboy - yeah this new code is gonna take us all a bit of getting into |
Overview
Add workflow template for recurring cancelled
Before
No workflow template class
After
Tada
Technical Details
This is a simple template, with a slightly smaller subset of values than the exisiting one.
It pulls out the recurring part to a trait... I think we want to also create similar traits for Contribuiton messages - which was going to be my next focus.
Comments
Test pre-added to CancelSubscriptionTest class testing these values