Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Unit test for 20602 #20745

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

#20602

@sluc23 This is what I was thinking - it fails before and passes after. I got the value of the input array by putting CRM_Core_Error::debug_log_message(var_export($_REQUEST, true)) at the beginning of getContactActivity(), and then visited an activity tab and set all the filters, then looked in the civi log.

@civibot
Copy link

civibot bot commented Jul 1, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@demeritcowboy I'm not sure if you want this merged or not at this stage but please self-merge if that is your intent

@demeritcowboy
Copy link
Contributor Author

Ok thanks. Yes it was intended to be merged.

@demeritcowboy demeritcowboy merged commit b86e1f5 into civicrm:master Jul 1, 2021
@demeritcowboy demeritcowboy deleted the test-20602 branch July 1, 2021 22:15
@sluc23
Copy link
Contributor

sluc23 commented Jul 2, 2021

thanks @demeritcowboy , I didn't figure it out to do it that way.
It's a good example for following tests that need to "simulate" browsing a page with parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants