Fix activity_date_time_relative filter when `preserve_activity_tab_fi…

[sluc23]

…lter` setting is on

Overview

When this setting is on Administer / Display Preferences / Customize Data and Screens / Preserve activity filters as a user preference the Activity Date filter is not properly saved.

Before

Replicated in dmaster:

After

Activity Date filter is properly saved.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • There's a pre-existing weirdness where viewing the activities dashlet won't use your settings but at the same time will clobber your settings. It's not from this PR.
• Developer standards
  • [r-tech] PASS
  • [r-code] PASS with suggestion
    • This is pre-existing but at line 441 when it sets the setting, it's possible for $activityFilter to have never been set, e.g. if you have no filters set on the activity tab. This generates an error every time someone first visits an activity tab after turning on the setting. Suggest putting $activityFilter = []; before the loop around line 421.
  • [r-maint] ?
    • It would be nice to have a test. It seems like you could get your setup variable by logging var_export($_REQUEST, true) from a live run, and then in the test set $_REQUEST to that and then call the function and then check the settings values.
  • [r-test] PASS

[sluc23]

@demeritcowboy :

• [r-code]: fixed
• [r-maint] : I'm struggling to do the test, because I dont' find a way where I can set up the setting preserve_activity_tab_filter, then setup some activity filters, and then check that the activity filters are still there.. 🤔

[colemanw]

I think this is ok without a test.

[demeritcowboy]

Ok thanks for trying. I was thinking maybe it would be an easy one.