dev/mail#89 Fix unreleased regression where civimember is not permitted/enabled #19594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed/enabled Fixes a bug where a person with no access to CiviMember will get an exception thrown (and not caught) rather than receive a result of 0 when checking the memberships that a contact has access to
|
(Standard links)
|
|
I was able to replicate the regression and confirmed that this fixed the problem merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a regression introduced in #19431 where users with no access to civimember get an error when saving relationships as an api exception is thrown
Before
Uncaught exception results in modal just spinning and if done outside a model it can be seen that ane exception was not caught
After
Exception caught in the function and 0 returned
Technical Details
Comments
This can be particularly confusing on sites where civimember is not enabled at all