Show disabled membership types on contact tab

[mattwire]

Overview

Replacement for #17143 / #17435 using API4 and retaining financialacl code.

Contacts may still have disabled membership types. But new memberships of that type cannot be created.

Before

Disabled memberships show in searches but not contact tab.

After

Disabled memberships show in searches and contact tab.

Technical Details

Use API4 MembershipType API to retrieve all membership types that the user has permission for. Added a comment that the code should be moved to the financialacl extension instead.
Set checkPermissions explicitly to TRUE (that is the default) because this allows the API to accurately return the membership types that the user has permission to access. For example another extension could control access.

Comments

@seamuslee001

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Bunch of test failures here @mattwire the code looks the right direction here @eileenmcnaughton I'm just thinking about the implications in the changes to CRM_Utils_Money::format here

[mattwire]

@seamuslee001 Oh sorry I've done it again. Those commits should not have been in this PR - now updated.

[seamuslee001]

@mattwire test fail relates https://test.civicrm.org/job/CiviCRM-Core-PR/38918/testReport/junit/(root)/api_v3_FinancialTypeACLTest/testMembersipTypeACLFinancialTypeACL/

[seamuslee001]

This change looks right to me now, I just have one minor r-code issue but I don't see any other issues with it @eileenmcnaughton

[eileenmcnaughton]

Yep I think this is mergeable with the switch @seamuslee001 suggested

[mattwire]

@eileenmcnaughton @seamuslee001 Thanks, tests now passing

[eileenmcnaughton]

Fix for regression caused by this #19594