Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Convert civi.tag-deprecated to use central function #19179

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

Converts usage of Civi::log() with the civi.tag deprecated to use a newly added central function which does the same thing. Have marked NFC since that's all it does but feel free to remove if it doesn't meet the criteria.

Before

Civi::log()->...(... ['civi.tag' => 'deprecated']);

After

CRM_Core_Error::deprecatedWarning('...');

Technical Details

Comments

There is one spot not included which is dealt with at #19167.

There are two other spots not included for which I have a most excellent reason but the margins here are too small to contain it.

@eileenmcnaughton @seamuslee001

@civibot
Copy link

civibot bot commented Dec 11, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Thanks @demeritcowboy - probably some code chunks we could remove based on long-time deprecation but I understand if you don't want to go through one by one - although it might make it slightly harder to spot the ones we can remove in gitlab

@demeritcowboy
Copy link
Contributor Author

Good point. I can take a look if some are already old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants