[NFC] Convert civi.tag-deprecated to use central function #19179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Converts usage of Civi::log() with the civi.tag deprecated to use a newly added central function which does the same thing. Have marked NFC since that's all it does but feel free to remove if it doesn't meet the criteria.
Before
Civi::log()->...(... ['civi.tag' => 'deprecated']);
After
CRM_Core_Error::deprecatedWarning('...');
Technical Details
Comments
There is one spot not included which is dealt with at #19167.
There are two other spots not included for which I have a most excellent reason but the margins here are too small to contain it.
@eileenmcnaughton @seamuslee001