Unused writeLegacyWarnings() in PropertyBag

[demeritcowboy]

Overview

Putting this up partly as a question since it came up while looking at stuff.

The thing that registered this function as a shutdown function was removed here: aa29942#diff-c8d9bcea3e41ecc2ae13f5b654fefbbe3e95a73c9066b83017af82204533f9d2L197

And the same commit removed the $legacyWarnings[] class member that holds the warnings, but left this block still there. I'm thinking just oversight since I can't find any other references to that property or this function.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@demeritcowboy jenkins wants a word https://test.civicrm.org/job/CiviCRM-Core-PR/38326/checkstyleResult/new/

[demeritcowboy]

Thanks. Needed to delete even more lines.

[eileenmcnaughton]

@artfulrobot seems fine to you?

[artfulrobot]

Yep all looks sensible to me.

[seamuslee001]

Thanks @artfulrobot

[demeritcowboy]

Thanks!