Remove unused params, return params from processFail #18998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Nov 21, 2020
Once civicrm#18997 & civicrm#18998 is merged it becomes clear that processContribution can never be true & hence this code is unreachable
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Nov 21, 2020
Once civicrm#18997 & civicrm#18998 is merged it becomes clear that processContribution can never be true & hence this code is unreachable
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Nov 21, 2020
Once civicrm#18997 & civicrm#18998 is merged it becomes clear that processContribution can never be true & hence this code is unreachable
|
This looks ok to me merging |
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Nov 22, 2020
Once civicrm#18997 & civicrm#18998 is merged it becomes clear that processContribution can never be true & hence this code is unreachable
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Nov 22, 2020
Once civicrm#18997 & civicrm#18998 is merged it becomes clear that processContribution can never be true & hence this code is unreachable
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Nov 23, 2020
Once civicrm#18997 & civicrm#18998 is merged it becomes clear that processContribution can never be true & hence this code is unreachable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Same as #18997 but for the process fail function
Before
Always FALSE variables passed in & returned
After
simplified
Technical Details
This has been made possible by reducing the information transitionComponents has to return in previous changes
Comments