Remove unused parameters from cancel

[eileenmcnaughton]

Overview

Follow up cleanup on BAO_Contribution::fail - remove always FALSE value and unused / always FALSE return values

Before

  protected static function cancel($processContributionObject, $memberships, $contributionId, $membershipStatuses, $updateResult, $participant, $oldStatus, $pledgePayment, $pledgeID, $pledgePaymentIDs, $contributionStatusId) {

After

poof

  protected static function cancel($memberships, $contributionId, $membershipStatuses, $participant, $oldStatus, $pledgePayment, $pledgeID, $pledgePaymentIDs, $contributionStatusId) {

Technical Details

cancel as a protected function is only called from one place and the processContribution value is always false.
This means that the returned processContribution value is always false - so we don't need to return
it as it is set to false already. In addition the currently returned updateResult is no longer
used so we don't need to return that either.

I will do the same changes in a separate PR for processFail

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@seamuslee001 this & the related are the next 2 minor cleanups on this code - basically we removed some functionality (onlinepending, details pop ups) from functions that called this so just working through all the stuff that is no longer needed

[eileenmcnaughton]

@seamuslee001 @colemanw can I get a merge on this & #18998 - in the end both functions will go altogether

[seamuslee001]

This looks ok to me merging