Follow up fix on paypal redirect #18534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -1919,8 +1919,7 @@ public static function sendResponse(\Psr\Http\Message\ResponseInterface $respons | |||
| * Perform any necessary actions prior to redirecting via POST. | |||
| */ | |||
| public static function prePostRedirect() { | |||
There was a problem hiding this comment.
Should we ditch this function?
Turns out we did some function renaming & missed a spot before merge. As an aside I fixed Paypal to call CRM_Core_Config::singleton()->userSystem->prePostRedirect() directly rather than via system. I'm tempted to take the System function back out again - I don't think it offers a better one-liner
608d736 to
67a10cc
Compare
|
test this please |
|
Looks fine to me |
|
thanks @seamuslee001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Turns out we did some function renaming & missed a spot before merging #18525 - this fixes
Before
Paypal std broken
After
works & has a a test that would have picked it up
Technical Details
As an aside I fixed Paypal to call CRM_Core_Config::singleton()->userSystem->prePostRedirect()
directly rather than via system. I'm tempted to take the System function back out
again - I don't think it offers a better one-liner
Comments