Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PayPal Standard session loss in WordPress (5.30) #18525

Merged
merged 1 commit into from
Sep 20, 2020

Conversation

christianwach
Copy link
Member

Overview

Fixes this issue on Lab. See issue for detailed discussion.

Replaces #18502 to merge against 5.30.

Before

PayPal Contribution completes in CiviCRM, but the user is stuck on an error page.

After

PayPal Contribution completes in CiviCRM as expected.

Comments

Other CMSes may still need to implement similar fixes, but can use the supplied CRM_Utils_SameSite class.

@civibot
Copy link

civibot bot commented Sep 19, 2020

(Standard links)

@civibot civibot bot added the master label Sep 19, 2020
@christianwach
Copy link
Member Author

@eileenmcnaughton I've renamed the methods in this PR - hope they're suitably generic.

@eileenmcnaughton
Copy link
Contributor

@christianwach yes looks good

Test fail feels unrelated

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

@kcristiano let me know if OK to merge

@kcristiano
Copy link
Member

@eileenmcnaughton I have done r-run in both sandbox mode and live. I used two CiviCRM sites, Firefox and Chrome on Linux, Safari on Mac.
I haven't been able to test all the user agents.

I do think it's better in than out, but I was hoping someone would have the ability to test old user agents.

@kcristiano
Copy link
Member

OK I just remembered a server I could run this with IE 11. So I've tested in IE 11 and it looks good.

@eileenmcnaughton eileenmcnaughton changed the base branch from master to 5.30 September 20, 2020 20:34
@civibot civibot bot added 5.30 and removed master labels Sep 20, 2020
@eileenmcnaughton eileenmcnaughton merged commit 420d358 into civicrm:5.30 Sep 20, 2020
@christianwach christianwach deleted the lab-core-1997-530 branch September 21, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants