dev/core#1982 - 5.29 version of PR 18282 #18301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
5.29 version of #18282 from @lcdservices
Case role shouldn't assign to creator if uncheck creator in the config.
Technical Details
SimpleXML node values don't behave the same as regular variables.
Comments
Also updated the other line that had the same flaw from #17012. To trigger that you'd have to have an unusual xml configuration via files or api, and in fact the original cast to bool would also have been wrong so it was probably always wrong.
Has test (5.29 version of #18287)