Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1982 - 5.29 version of PR 18282 #18301

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

5.29 version of #18282 from @lcdservices

Case role shouldn't assign to creator if uncheck creator in the config.

Technical Details

SimpleXML node values don't behave the same as regular variables.

Comments

Also updated the other line that had the same flaw from #17012. To trigger that you'd have to have an unusual xml configuration via files or api, and in fact the original cast to bool would also have been wrong so it was probably always wrong.

Has test (5.29 version of #18287)

@civibot
Copy link

civibot bot commented Aug 31, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

This is a reviewer's commit -mop

@eileenmcnaughton eileenmcnaughton merged commit 3031dcf into civicrm:5.29 Sep 1, 2020
@demeritcowboy demeritcowboy deleted the dev-core-1982-5.29 branch September 1, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants