dev/core#1982 fix creator param handling

[lcdservices]

Overview

Case open: doesn't respect case roles "creator" param if unset

to replicate:

1. create a new casetype
2. in the list of case roles, uncheck the "assign to creator" checkbox for the default case coordinator role
3. create a new case on a contact record

Before

case coordinator role is created and assigned to the logged in user

After

no case coordinator role created

Technical Details

simple fix to the condition that determines if the relationship should be created.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Looks like I broke it. I see simplexml returns the property as an array if you don't cast it or force conversion.

This would have been 5.26 so should this go against 5.29 as a regression?

Also line 108 below should maybe also get !empty or be cast to (bool).

[eileenmcnaughton]

Adding has-test as @demeritcowboy has written a test. Also looks like this should be against 5.29 - am I right in thinking this should be merged as soon as we have a passing PR against 5.29?

[demeritcowboy]

Made 5.29 version at #18301 and also updated the other line that needs wrapping.

[eileenmcnaughton]

Closing as merged via #18301