Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum upgradable version to 4.4.7 #17750

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 4, 2020

Overview

CiviCRM v4.4. was released back in 2013. How time flies! This PR bumps the minimum upgradable version from 4.2.9 to 4.4.7.

Before

Technically possible to upgrade from 4.2 (although probably not a good idea).

After

Now you must be on at least 4.4.7 to upgrade (which is not quite as ancient).

Technical Details

Although there were other releases in the 4.4 LTS series, none of them contained any schema changes or upgrade steps; 4.4.7 is the last release to modify the schema in that series, which is why I picked that version as the minimum.

Comment

I've also added an update to the documentation: civicrm/civicrm-sysadmin-guide#253

@civibot
Copy link

civibot bot commented Jul 4, 2020

(Standard links)

@civibot civibot bot added the master label Jul 4, 2020
@colemanw
Copy link
Member Author

colemanw commented Jul 4, 2020

@totten would you be able to do a little maintenance on the upgrade tests so this can pass jenkins? It's time to cull old test DBs < 4.4.7 and probably generate a new multilingual DB to replace the one from 4.2.

@eileenmcnaughton
Copy link
Contributor

I think it's time.... @MikeyMJCO asked the right questions on the docs PR

@seamuslee001
Copy link
Contributor

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

@colemanw error now is

Smarty error: unable to read resource:                                 [warning]
&quot;/home/jenkins/bknix-dfl/build/core-17750-4l4r8/web/sites/all/modules/civicrm/CRM/Upgrade/Incremental/sql/4.4.7.mysql.tpl&quot

@colemanw
Copy link
Member Author

colemanw commented Jul 6, 2020

That's strange. Why would a 4.5 upgrade be trying to access a 4.4 upgrade file?
Looks like there's more info at /home/jenkins/bknix-dfl/build/core-17750-4l4r8/.civibuild/debug/4.5.0-setupsh.sql.bz2.log on the server. I'm having trouble logging into the jenkins box - are you able to open that file?

@seamuslee001
Copy link
Contributor

@colemanw the reason is because of https://github.com/civicrm/civicrm-core/blob/master/CRM/Upgrade/Incremental/php/FourSix.php#L130

@colemanw
Copy link
Member Author

colemanw commented Jul 7, 2020

Thanks @seamuslee001, good detective work. I've added that sql file back in.

@seamuslee001
Copy link
Contributor

Merging now that tests have passed

@seamuslee001 seamuslee001 merged commit 004eff0 into civicrm:master Jul 7, 2020
@seamuslee001 seamuslee001 deleted the upgradeBump branch July 7, 2020 06:06
@colemanw
Copy link
Member Author

colemanw commented Jul 7, 2020

Thanks @seamuslee001 for seeing it through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants