[REF] Code simplification & unit test on suppressed emails in task #17393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code simplification, add test
Before
Long winded code -
in Build form
$this->_contactDetails
to what is effectively the result of a contact.get on the idsfiltered by $this->_allContactIds
$this->_contactDetails
in submit
De-wrangle the contacts by array-diffing the 2 arrays above to get the suppressed ones & then wrangling them for a message
After
Set the suppressed emails in the first place as their own array, using the final required style
Technical Details
Comments