Convert to Field on email Trait to entity reference

[eileenmcnaughton]

Overview

This changes the to field when doing a stand-alone email from a weird java-scripty field to an entity reference field

Before

Lots of custom js fo the to field

After

Entity reference, like with cc & bcc fields

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw I think this is the commit for the last entity ref field on that form now. I have had a lot of preliminaries merged to get to a somewhat readable switch over

[eileenmcnaughton]

@demeritcowboy any chance you could review this for me - it could do with your 'eye-for-gotchas' - it replaces the 'to field' on all the screens for sending emails to one or more contacts (but not civimails)

[demeritcowboy]

Sure, can look tomorrow.

[eileenmcnaughton]

thanks!

[demeritcowboy]

One thing is that if you're on a contact view page and from the actions dropdown choose Send Email, it no longer prepopulates the To field. It's not immediately obvious why. Ditto if you initiate an email from Manage Case in the roles section.

[eileenmcnaughton]

@demeritcowboy thanks - I'll check it out

[demeritcowboy]

Oh actually looking at it now afresh it's probably toContact in the template.

[eileenmcnaughton]

@demeritcowboy yes - it looks like it needs setDefaultValues - the code is so awful that coming back to it again I can't make much sense of it :-(

I put up this minor simplification #17873 for now

[eileenmcnaughton]

I'm going to close this for now - per comments on #17873