dev/core#1738 Fix opening specific contribution page tab from Manage Contribution Pages

CRM/Contribute/Form/ContributionPage/Amount.php

@@ -32,6 +32,14 @@ class CRM_Contribute_Form_ContributionPage_Amount extends CRM_Contribute_Form_Co
    */
   const NUM_OPTION = 11;
 
+  /**
+   * Set variables up before form is built.
+   */
+  public function preProcess() {
+    parent::preProcess();
+    $this->setSelectedChild('amount');
+  }
+
   /**
    * Build the form object.
    */

CRM/Contribute/Form/ContributionPage/Custom.php

@@ -19,6 +19,14 @@
  */
 class CRM_Contribute_Form_ContributionPage_Custom extends CRM_Contribute_Form_ContributionPage {
 
+  /**
+   * Set variables up before form is built.
+   */
+  public function preProcess() {
+    parent::preProcess();
+    $this->setSelectedChild('custom');
+  }
+
   /**
    * Build the form object.
    */

CRM/Contribute/Form/ContributionPage/Premium.php

@@ -20,6 +20,14 @@
  */
 class CRM_Contribute_Form_ContributionPage_Premium extends CRM_Contribute_Form_ContributionPage {
 
+  /**
+   * Set variables up before form is built.
+   */
+  public function preProcess() {
+    parent::preProcess();
+    $this->setSelectedChild('premium');
+  }
+
   /**
    * Set default values for the form.
    */

CRM/Contribute/Form/ContributionPage/Settings.php

@@ -21,6 +21,7 @@ class CRM_Contribute_Form_ContributionPage_Settings extends CRM_Contribute_Form_
    */
   public function preProcess() {
     parent::preProcess();
+    $this->setSelectedChild('settings');
   }
 
   /**

CRM/Contribute/Form/ContributionPage/ThankYou.php

@@ -20,6 +20,14 @@
  */
 class CRM_Contribute_Form_ContributionPage_ThankYou extends CRM_Contribute_Form_ContributionPage {
 
+  /**
+   * Set variables up before form is built.
+   */
+  public function preProcess() {
+    parent::preProcess();
+    $this->setSelectedChild('thankyou');
+  }
+
   /**
    * Set default values for the form.
    *

CRM/Contribute/Form/ContributionPage/Widget.php

@@ -21,6 +21,7 @@ class CRM_Contribute_Form_ContributionPage_Widget extends CRM_Contribute_Form_Co
 
   public function preProcess() {
     parent::preProcess();
+    $this->setSelectedChild('widget');
 
     $this->_widget = new CRM_Contribute_DAO_Widget();
     $this->_widget->contribution_page_id = $this->_id;

CRM/Core/Form.php

@@ -2571,4 +2571,19 @@ protected function isFormInViewOrEditMode() {
     ]);
   }
 
+  /**
+   * Set the active tab
+   *
+   * @param string $default
+   *
+   * @throws \CRM_Core_Exception
+   */
+  public function setSelectedChild($default = NULL) {
+    $selectedChild = CRM_Utils_Request::retrieve('selectedChild', 'Alphanumeric', $this, FALSE, $default);
+    if (!empty($selectedChild)) {
+      $this->set('selectedChild', $selectedChild);
+      $this->assign('selectedChild', $selectedChild);
+    }
+  }
+
 }

CRM/Event/Form/ManageEvent.php

@@ -84,21 +84,6 @@ public function getDefaultContext() {
     return 'create';
   }
 
-  /**
-   * Set the active tab
-   *
-   * @param string $default
-   *
-   * @throws \CRM_Core_Exception
-   */
-  public function setSelectedChild($default = NULL) {
-    $selectedChild = CRM_Utils_Request::retrieve('selectedChild', 'Alphanumeric', $this, FALSE, $default);
-    if (!empty($selectedChild)) {
-      $this->set('selectedChild', $selectedChild);
-      $this->assign('selectedChild', $selectedChild);
-    }
-  }
-
   /**
    * Set variables up before form is built.
    */

CRM/Friend/Form/Contribute.php

@@ -32,6 +32,7 @@ class CRM_Friend_Form_Contribute extends CRM_Contribute_Form_ContributionPage {
 
   public function preProcess() {
     parent::preProcess();
+    $this->setSelectedChild('friend');
   }
 
   /**

CRM/Member/Form/MembershipBlock.php

@@ -9,12 +9,6 @@
  +--------------------------------------------------------------------+
  */
 
-/**
- *
- * @package CRM
- * @copyright CiviCRM LLC https://civicrm.org/licensing
- */
-
 /**
  * form to process actions on Membership
  */
@@ -26,15 +20,19 @@ class CRM_Member_Form_MembershipBlock extends CRM_Contribute_Form_ContributionPa
    */
   protected $_memPriceSetId = NULL;
 
+  /**
+   * Set variables up before form is built.
+   */
+  public function preProcess() {
+    parent::preProcess();
+    $this->setSelectedChild('membership');
+  }
+
   /**
    * Set default values for the form. Note that in edit/view mode
    * the default values are retrieved from the database
-   *
-   *
-   * @return void
    */
   public function setDefaultValues() {
-    //parent::setDefaultValues();
     $defaults = [];
     if (isset($this->_id)) {
       $defaults = CRM_Member_BAO_Membership::getMembershipBlock($this->_id);
@@ -94,7 +92,8 @@ public function setDefaultValues() {
   /**
    * Build the form object.
    *
-   * @return void
+   * @throws \CRM_Core_Exception
+   * @throws \CiviCRM_API3_Exception
    */
   public function buildQuickForm() {
     $membershipTypes = CRM_Member_BAO_MembershipType::getMembershipTypes();
@@ -207,12 +206,13 @@ public function buildQuickForm() {
    *
    * @param array $params
    *   (ref.) an assoc array of name/value pairs.
-   *
    * @param $files
    * @param int $contributionPageId
    *
    * @return bool|array
    *   mixed true or array of errors
+   * @throws \CRM_Core_Exception
+   * @throws \CiviCRM_API3_Exception
    */
   public static function formRule($params, $files, $contributionPageId = NULL) {
     $errors = [];
@@ -315,8 +315,6 @@ public static function formRule($params, $files, $contributionPageId = NULL) {
 
   /**
    * Process the form.
-   *
-   * @return void
    */
   public function postProcess() {
     // get the submitted form values.

CRM/PCP/Form/Contribute.php

@@ -32,6 +32,7 @@ class CRM_PCP_Form_Contribute extends CRM_Contribute_Form_ContributionPage {
 
   public function preProcess() {
     parent::preProcess();
+    $this->setSelectedChild('pcp');
   }
 
   /**