Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1738 Fix opening specific contribution page tab from Manage Contribution Pages #17190

Merged

Conversation

mattwire
Copy link
Contributor

Overview

Per https://lab.civicrm.org/dev/core/-/issues/1738 ping @jitendrapurohit

Before

Stopped working for contribution pages following #17066

After

Works again.

Technical Details

This is now consistent with how manage event tabs work! It would be simpler if both events and contribution pages used the selectedChild parameter instead of their own URLs for each tab but that is a much bigger change.

Comments

@jitendrapurohit @eileenmcnaughton fix for unreleased regression

@civibot
Copy link

civibot bot commented Apr 29, 2020

(Standard links)

@civibot civibot bot added the master label Apr 29, 2020
@mattwire mattwire force-pushed the contributionpageselectedchildfromactions branch from f6910a7 to 7885e66 Compare April 29, 2020 10:50
@eileenmcnaughton
Copy link
Contributor

Code looks OK - @jitendrapurohit does this fix it for you?

@jitendrapurohit
Copy link
Contributor

Tested this on contribution and event page. I've confirmed that the bug is fixed now. Thanks for the PR @mattwire 👍

@seamuslee001 seamuslee001 merged commit d467e32 into civicrm:master Apr 30, 2020
@eileenmcnaughton
Copy link
Contributor

Thanks @mattwire , @jitendrapurohit

@mattwire mattwire deleted the contributionpageselectedchildfromactions branch May 4, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants