Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Start transitioning EmailCommon class to a trait #16935

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This change does not change behaviour but starts the process of using a trait to cleanup the EmailCommon class (which is currently awful)

Before

Form passed to static functions

After

Starting to use a trait

Technical Details

This is a really awful class - I've added a trait & moved the calls from the various forms to that trait
so the code on EmailCommon for buildForm is now only called once. I will follow up with more the same

Comments

@civibot
Copy link

civibot bot commented Mar 31, 2020

(Standard links)

This is a really awful class - I've added a trait &  moved the calls from the various forms to that trait
so the code  on EmailCommon for buildForm is now only called once. I will follow up with more the same
@colemanw colemanw merged commit 5e15147 into civicrm:master Apr 1, 2020
@colemanw colemanw deleted the email_common branch April 1, 2020 09:37
@colemanw
Copy link
Member

colemanw commented Apr 1, 2020

Nice cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants