[REF] Start transitioning EmailCommon class to a trait

This is a really awful class - I've added a trait &  moved the calls from the various forms to that trait
so the code  on EmailCommon for buildForm is now only called once. I will follow up with more the same

CRM/Activity/Form/Task/Email.php

@@ -19,6 +19,7 @@
  * This class provides the functionality to email a group of contacts.
  */
 class CRM_Activity_Form_Task_Email extends CRM_Activity_Form_Task {
+  use CRM_Contact_Form_Task_EmailTrait;
 
   /**
    * Are we operating in "single mode", i.e. sending email to one
@@ -39,6 +40,8 @@ class CRM_Activity_Form_Task_Email extends CRM_Activity_Form_Task {
 
   /**
    * Build all the data structures needed to build the form.
+   *
+   * @throws \CiviCRM_API3_Exception
    */
   public function preProcess() {
     CRM_Contact_Form_Task_EmailCommon::preProcessFromAddress($this);
@@ -49,20 +52,15 @@ public function preProcess() {
 
   /**
    * Build the form object.
+   *
+   * @throws \CRM_Core_Exception
    */
   public function buildQuickForm() {
     // Enable form element.
     $this->assign('emailTask', TRUE);
     CRM_Contact_Form_Task_EmailCommon::buildQuickForm($this);
   }
 
-  /**
-   * Process the form after the input has been submitted and validated.
-   */
-  public function postProcess() {
-    CRM_Contact_Form_Task_EmailCommon::postProcess($this);
-  }
-
   /**
    * List available tokens for this form.
    *

CRM/Contact/Form/Task/Email.php

@@ -139,13 +139,6 @@ public function buildQuickForm() {
     CRM_Contact_Form_Task_EmailCommon::buildQuickForm($this);
   }
 
-  /**
-   * Process the form after the input has been submitted and validated.
-   */
-  public function postProcess() {
-    CRM_Contact_Form_Task_EmailCommon::postProcess($this);
-  }
-
   /**
    * List available tokens for this form.
    *

CRM/Contact/Form/Task/EmailTrait.php

@@ -0,0 +1,34 @@
+<?php
+/*
+ +--------------------------------------------------------------------+
+ | Copyright CiviCRM LLC. All rights reserved.                        |
+ |                                                                    |
+ | This work is published under the GNU AGPLv3 license with some      |
+ | permitted exceptions and without any warranty. For full license    |
+ | and copyright information, see https://civicrm.org/licensing       |
+ +--------------------------------------------------------------------+
+ */
+
+/**
+ *
+ * @package CRM
+ * @copyright CiviCRM LLC https://civicrm.org/licensing
+ */
+
+/**
+ * This class provides the common functionality for tasks that send emails.
+ */
+trait CRM_Contact_Form_Task_EmailTrait {
+
+  /**
+   * Process the form after the input has been submitted and validated.
+   *
+   * @throws \CRM_Core_Exception
+   * @throws \CiviCRM_API3_Exception
+   * @throws \Civi\API\Exception\UnauthorizedException
+   */
+  public function postProcess() {
+    CRM_Contact_Form_Task_EmailCommon::postProcess($this);
+  }
+
+}

CRM/Contribute/Form/Task/Email.php

@@ -19,6 +19,7 @@
  * This class provides the functionality to email a group of contacts.
  */
 class CRM_Contribute_Form_Task_Email extends CRM_Contribute_Form_Task {
+  use CRM_Contact_Form_Task_EmailTrait;
 
   /**
    * Are we operating in "single mode", i.e. sending email to one
@@ -60,13 +61,6 @@ public function buildQuickForm() {
     CRM_Contact_Form_Task_EmailCommon::buildQuickForm($this);
   }
 
-  /**
-   * Process the form after the input has been submitted and validated.
-   */
-  public function postProcess() {
-    CRM_Contact_Form_Task_EmailCommon::postProcess($this);
-  }
-
   /**
    * List available tokens for this form.
    *

CRM/Event/Form/Task/Email.php

@@ -13,14 +13,14 @@
  *
  * @package CRM
  * @copyright CiviCRM LLC https://civicrm.org/licensing
- * $Id: Email.php 45499 2013-02-08 12:31:05Z kurund $
  */
 
 /**
  * This class provides the functionality to email a group of
  * contacts.
  */
 class CRM_Event_Form_Task_Email extends CRM_Event_Form_Task {
+  use CRM_Contact_Form_Task_EmailTrait;
 
   /**
    * Are we operating in "single mode", i.e. sending email to one
@@ -68,13 +68,6 @@ public function buildQuickForm() {
     CRM_Contact_Form_Task_EmailCommon::buildQuickForm($this);
   }
 
-  /**
-   * Process the form after the input has been submitted and validated.
-   */
-  public function postProcess() {
-    CRM_Contact_Form_Task_EmailCommon::postProcess($this);
-  }
-
   /**
    * List available tokens for this form.
    *

CRM/Member/Form/Task/Email.php

@@ -13,15 +13,14 @@
  *
  * @package CRM
  * @copyright CiviCRM LLC https://civicrm.org/licensing
- * $Id: Email.php 45499 2013-02-08 12:31:05Z kurund $
- *
  */
 
 /**
  * This class provides the functionality to email a group of
  * contacts.
  */
 class CRM_Member_Form_Task_Email extends CRM_Member_Form_Task {
+  use CRM_Contact_Form_Task_EmailTrait;
 
   /**
    * Are we operating in "single mode", i.e. sending email to one
@@ -50,6 +49,9 @@ class CRM_Member_Form_Task_Email extends CRM_Member_Form_Task {
    * Build all the data structures needed to build the form.
    *
    * @return void
+   *
+   * @throws \CRM_Core_Exception
+   * @throws \CiviCRM_API3_Exception
    */
   public function preProcess() {
     CRM_Contact_Form_Task_EmailCommon::preProcessFromAddress($this);
@@ -64,8 +66,8 @@ public function preProcess() {
   /**
    * Build the form object.
    *
-   *
    * @return void
+   * @throws \CRM_Core_Exception
    */
   public function buildQuickForm() {
     //enable form element
@@ -74,16 +76,6 @@ public function buildQuickForm() {
     CRM_Contact_Form_Task_EmailCommon::buildQuickForm($this);
   }
 
-  /**
-   * Process the form after the input has been submitted and validated.
-   *
-   *
-   * @return void
-   */
-  public function postProcess() {
-    CRM_Contact_Form_Task_EmailCommon::postProcess($this);
-  }
-
   /**
    * List available tokens for this form.
    *