Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch contact/activity update with radio options #16815

Closed

Conversation

ray-wright
Copy link
Contributor

To account for radio option values that contain a space, wrap the value name in quotes.

Overview

When updating multiple contacts, activities, etc the 'copy value from first row' is problematic with radio options.

Before

If the column is a radio field and the value in the first row contains a space, they copy from first row errors and does fails to set the value down the list. Console error shows:

Uncaught Error: Syntax error, unrecognized expression: [value=Value with space]

After

With the additional quotes around the value, you can copy the radio value from the first row and apply to the entire list.

Comments

This only affected the radio values, other field type values with spaces updated without issues.

Bring my fork up to date
Wrap radio value in single quotes to account for options with spaces.
@civibot
Copy link

civibot bot commented Mar 17, 2020

(Standard links)

@civibot civibot bot added the master label Mar 17, 2020
@colemanw
Copy link
Member

This indeed looks like the correct fix. The only issue with this PR is the extra 2 merge commits. Are you able to rebase those out?

@ray-wright
Copy link
Contributor Author

@colemanw I couldn't figure out how to do it in this patch but I can submit another patch with just the one commit - does that work?

@colemanw
Copy link
Member

Sure. Whatever works for you :)

@colemanw colemanw closed this Mar 19, 2020
@ray-wright
Copy link
Contributor Author

Great - I am actively working on getting better at tracking my own code and submitting PRs. Here's the new one: #16855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants