Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sybunt to select mark rows as selected #15872

Merged
merged 1 commit into from
Nov 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fixes a probably-not-that-recent bug where sybunt custom search does not permit contacts to be marked as selected

Before

Doing a Sybunt custom search & then selecting rows does not increment the 'selected' value

After

The selected value is incremented

Technical Details

With sort_name being retrievable the prevnext cache fails to fill. This is quietly caught - I also changed it to be more noisily caught

Comments

@seamuslee001 found while checking #15820 n& https://lab.civicrm.org/dev/core/issues/1377

@civibot
Copy link

civibot bot commented Nov 17, 2019

(Standard links)

@civibot civibot bot added the 5.20 label Nov 17, 2019
@seamuslee001
Copy link
Contributor

@eileenmcnaughton i have tested this and works as expected, i also checked other custom searches and found that the Price Set Custom Search was also an issue

@seamuslee001
Copy link
Contributor

sorry not price set event totals custom search

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 shall we merge this one

@seamuslee001
Copy link
Contributor

Yeh, the event aggregate custom search is the one that is then of issue but its an odd one

@seamuslee001 seamuslee001 merged commit 0a707f4 into civicrm:5.20 Nov 17, 2019
@seamuslee001 seamuslee001 deleted the sybunt branch November 17, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants