dev/core#183 Finish converting contrib sybnt custom search to using t… #15820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@seamuslee001 this gives a fatal - just leave off the category IMHO - I don't think it adds anything here - just complexity
|
65b951e to
6b14f61
Compare
|
ok @eileenmcnaughton have removed that now |
|
I re-tested this & it worked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…em table class
Overview
The contribution SYBNT custom search had already had some temporary tables convert to using CRM_Utils_SQL_TempTable, this just finished the job off
Before
Some legacy ways of creating temp tables still used
After
CRM_Utils_SQL_TempTable class used
ping @eileenmcnaughton @totten