Add in unit test for dev/mailing#56 and dev/mailing#57 and also fix i… #15782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssue where by mailing_name has been namespaced also in 5.20
Overview
This adds a unit test to verify the fix for dev/mailing#56 and dev/mailing#57. It also handles another situation of the same problem which is that mailing_name has been namespaced in 5.20 08d08c0 and when running the unit test locally without the changes in CRM/Mailing/BAO/Mailing a new notice was thrown
Before
No unit test and e-notice thrown when running mailing report about mailing_name
After
unit test and no e-notice
ping @eileenmcnaughton @monishdeb @demeritcowboy