Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in unit test for dev/mailing#56 and dev/mailing#57 and also fix i… #15782

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

seamuslee001
Copy link
Contributor

…ssue where by mailing_name has been namespaced also in 5.20

Overview

This adds a unit test to verify the fix for dev/mailing#56 and dev/mailing#57. It also handles another situation of the same problem which is that mailing_name has been namespaced in 5.20 08d08c0 and when running the unit test locally without the changes in CRM/Mailing/BAO/Mailing a new notice was thrown

Before

No unit test and e-notice thrown when running mailing report about mailing_name

After

unit test and no e-notice

ping @eileenmcnaughton @monishdeb @demeritcowboy

@civibot
Copy link

civibot bot commented Nov 8, 2019

(Standard links)

@civibot civibot bot added the 5.20 label Nov 8, 2019
…ssue where by mailing_name has been namespaced also in 5.20
@seamuslee001 seamuslee001 merged commit 0f1268b into civicrm:5.20 Nov 8, 2019
@seamuslee001 seamuslee001 deleted the dev_mailing_56_2 branch November 8, 2019 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants