Add in unit test for dev/mailing#56 and dev/mailing#57 and also fix i…

…ssue where by mailing_name has been namespaced also in 5.20

CRM/Mailing/BAO/Mailing.php

@@ -1839,9 +1839,7 @@ public static function &report($id, $skipDetails = FALSE, $isSMS = FALSE) {
 
     $report['mailing'] = [];
     foreach (array_keys(self::fields()) as $field) {
-      if ($field == 'mailing_modified_date') {
-        $field = 'modified_date';
-      }
+      $field = self::fields()[$field]['name'];
       $report['mailing'][$field] = $mailing->$field;
     }
 

tests/phpunit/api/v3/JobProcessMailingTest.php

@@ -177,6 +177,12 @@ public function testPauseAndResumeMailing() {
     //Execute the job and it should send the mailing to the recipients now.
     $this->callAPISuccess('job', 'process_mailing', []);
     $this->_mut->assertRecipients($this->getRecipients(1, 2));
+    // Ensure that loading the report produces no errors.
+    $report = CRM_Mailing_BAO_Mailing::report($result['id']);
+    // dev/mailing#56 dev/mailing#57 Ensure that for completed mailings the jobs array is not empty.
+    $this->assertTrue(!empty($report['jobs']));
+    // Ensure that mailing name is correctly stored in the report.
+    $this->assertEuqals('mailing name', $report['name']);
   }
 
   /**