dev/core#1059 Fix contribution search to work with url parameters in force mode #14624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton can you rebase pls? |
This adds url support for sort_name & participant_status_id & participant_register_date to event search civicrm/event/search?reset=1&sort_name=p&participant_status_id=1&participant_register_date_low=20180101
…force mode Note this is part of the general 'convert receive_date to datepicker' work
69978ad to
a1c22f9
Compare
|
I went back to 4.5 and confirmed that using force ignores all other defaults merging |
|
@seamuslee001 cross fingers we've found 'all the places' - have you retested batch search? I haven't yet. Maybe we should add it to the rc list |
|
@eileenmcnaughton yes re tested there and seems to be working fine |
|
@seamuslee001 great - we might be through it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an additional PR in the work on converting receive_date to a datepicker - it fixes an issue where url parameters were not being respected in force mode
Before
From manage contribution page choose contributions this month - date criteria not applied
After
Date criteria applied
Technical Details
@seamuslee001 this is the missing piece on your PR - not I will rebase out the patch from #14477 once this is merged
Comments
I couldn't find other references to 'contribution_date' - I think there is a test for relative dates that references it still which should probably be fixed...