Ensure that completed status is selected by default on search contrib… #14612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
pradpnayak
reviewed
Jun 23, 2019
CRM/Contribute/Form/Search.php
Outdated
| if (empty($this->_defaults['contribution_status'])) { | ||
| $this->_defaults['contribution_status'][1] = 1; | ||
| if (empty($this->_defaults['contribution_status_id'])) { | ||
| $this->_defaults['contribution_status_id'][1] = 1; |
There was a problem hiding this comment.
Hardcoded?
$this->_defaults['contribution_status_id'][1] = CRM_Core_PseudoConstant::getKey(
'CRM_Contribute_BAO_Contribution',
'contribution_status_id',
'Completed'
);
There was a problem hiding this comment.
Thanks @pradpnayak good point have changed to the PseudoConstant
2dafc3b to
cf98098
Compare
|
Jenkins re test this please |
|
@seamuslee001 I guess that makes sense but note that - #14624 changes it to not kick in under force |
|
@eileenmcnaughton i think that is ok but i would appreciate others thoughts re the force side of things |
|
@seamuslee001 from my testing the force is keeping the old behaviour - ie try going from manage contribution page to the contributions from that page this month in an older version - I think it is not enforcing a status |
…ution form Use PseudoConstant function as label could change (good point thanks pradeep)
cf98098 to
8f8147e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ution form
Overview
This fixes a small bug where when loading the contribution form the status field doesn't have a default of completed status.
Before
After
ping @eileenmcnaughton @monishdeb @mattwire