Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] Move retrieval of basicSearchFields to 'get' fn #14476

Merged
merged 1 commit into from
Jun 7, 2019
Merged

[REF] Move retrieval of basicSearchFields to 'get' fn #14476

merged 1 commit into from
Jun 7, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jun 7, 2019 •
edited
Loading

Overview

Minor function extraction

Before

Code less readable

After

Code more readable

Technical Details

This is a partial of #14418 & as such am giving merge on pass as a reviewer's commit

Comments

@civibot
Copy link

civibot bot commented Jun 7, 2019

(Standard links)

@civibot civibot bot added the master label Jun 7, 2019
@eileenmcnaughton eileenmcnaughton changed the title Move retrieval of basicSearchFields to 'get' fn [REF] Move retrieval of basicSearchFields to 'get' fn Jun 7, 2019
@eileenmcnaughton eileenmcnaughton mentioned this pull request Jun 7, 2019
Closed
@eileenmcnaughton eileenmcnaughton merged commit dfb2d79 into civicrm:master Jun 7, 2019
@eileenmcnaughton eileenmcnaughton deleted the basic_search branch June 7, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eileenmcnaughton