dev/core#692 Unable to use url search arguments in 'Advanced Search' using force=1

[monishdeb]

Overview

Currently, it is not possible to use URL search arguments in 'Advanced Search' using force=1 to load search results. This is no longer working except for mailing params which are manually handled here

https://lab.civicrm.org/dev/core/issues/692

Before

You cannot use any search parameters as url arguments to load search results in 'Advance Search'.

After

You cannot use contact search parameters as url arguments to load search results in 'Advanced Search'. Here are two examples:

1. Using contact_type=Individual
   

2. Log date = true AND log_date_relative = This calendar month
   

3. Privacy options - do_not_email + privacy operator - AND + privacy toggle - Include
   

Technical Details

This fix is made for Contact search fields and can be extended for other component's search forms.
Please check the issue description here for more details.

Comments

ping @lcdservices @eileenmcnaughton @seamuslee001

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[lcdservices]

I ran through a number of tests and this works as expected.

[colemanw]

@monishdeb test failures may be related.
@civicrm-builder retest this please

[monishdeb]

@colemanw seems like test build is triggered again somehow.

[colemanw]

@monishdeb I triggered it with my comment. Here are the previous results: https://test.civicrm.org/job/CiviCRM-Core-PR/26673/

[eileenmcnaughton]

@monishdeb my worry is that this is using metadata but it's pushing in a different direction & using different constructs than what we have been doing on other forms. I just converted one field using our methodologies from the other forms - #14475 - I also have a thought how better to combine with the existing getBasicSearchFields fn but I figure if we can extract that first it will be clearer - so I put in #14476

[eileenmcnaughton]

@monishdeb so this picks off a couple more fields in a way that is consistent with work on other forms

https://github.com/civicrm/civicrm-core/pull/14921/files

Note the metadata drives the field being added to the form, grouped on the template and the loading of defaults

[eileenmcnaughton]

@monishdeb I feel like we superceded this one...

Once we fork for 5.17 we will probably convert some more datepicker fields which should implicitly add them to the url-supported fields.

I'd rather do a small number of fields at a time & deal with the tech issues each one throws up (if any)

[mlutfy]

Hi Monish,

I will close this PR for now because it is stale, but feel free to re-open when it's ready for a new round of review.