dev/core#1017: Always bootstrap CRM_Utils_System against 5.14

[agileware-fj]

Overview

Changes the legacy Paypal IPN endpoint to always bootstrap the user system, to avoid an error caused by e878028. This was already being done for Joomla, Drupal, and Backdrop, but needs to happen for WordPress as well.

Before

Posting to extern/ipn.php fails on WordPress with Uncaught Error: Call to undefined function get_option()

After

extern.ipn.php works on WordPress as well as Joomla, Drupal, and Backdrop

Comments

Reapplication of #14428 against 5.14 rc branch

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@kcristiano @christianwach I'm merging this as it's consistent with the other CMS

[christianwach]

@eileenmcnaughton As you're probably aware, WordPress will ultimately have to use this REST route instead of extern/ipn.php once the CiviCRM WP REST API Wrapper plugin is merged into the CiviCRM WordPress plugin to avoid the inherent problems with bootstrapping WordPress from within a plugin. If this serves as a temporary fix that works on the majority of WordPress installs, then it's fine by me.

[eileenmcnaughton]

@christianwach I wasn't aware of that - most IPNS should already be avoiding this file & going via civicrm/payment/ipn path for paypal & other processors but there is a long tail....

[christianwach]

@eileenmcnaughton Ah yes, of course... that new route sidesteps the bootstrap problem that extern/ipn.php has. Perhaps it would be helpful to have some docs that strongly deprecating the legacy route? Or one of CiviCRM's famous "System Status: Critical" dialogs? ;-)

[eileenmcnaughton]

lol - I think the docs do recommend the correct IPN now? It's configured in paypal so system status can't detect it

[mattwire]

The issue here, as I understand it and @seamuslee001 explained to me is that for existing paypal recurring you cannot change the IPN URL. So you are stuck with the extern/ipn.php forever unless you get those users to sign up again. The docs are already pretty clear I think.

[christianwach]

for existing paypal recurring you cannot change the IPN URL

@mattwire FFS :-(

Good to hear that the docs are up-to-date.

gets coat