dev/core#1017: Always bootstrap CRM_Utils_System for extern/ipn.php

[agileware-fj]

Overview

Changes the legacy Paypal IPN endpoint to always bootstrap the user system. This was already being done for Joomla, Drupal, and Backdrop, but needs to happen for WordPress as well.

Before

Posting to extern/ipn.php fails on WordPress with Uncaught Error: Call to undefined function get_option()

After

extern.ipn.php works on WordPress as well as Joomla, Drupal, and Backdrop

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton thoughts?

[agileware-fj]

I'll say it again here: I don't know why the Joomla call would be different.

Seeing as I don't have any Joomla systems to test this on, I've left the switch in though.

[seamuslee001]

also ping @mattwire @MegaphoneJon

[eileenmcnaughton]

if that is tested with WP we should merge - but into 5.14 rc

[agileware-fj]

This is tested on WordPress insofar as:

-bash-4.2$ php -a
Interactive shell

php > require_once 'wp-content/plugins/civicrm/civicrm/civicrm.config.php';
php > print CRM_Core_Config::singleton()->userSystem->getTimeZoneString();
PHP Warning:  Uncaught Error: Call to undefined function get_option() in /var/www/vhosts/example.org/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress.php:783
Stack trace:
#0 php shell code(1): CRM_Utils_System_WordPress->getTimeZoneString()
#1 {main}
  thrown in /var/www/vhosts/example.org/httpdocs/wp-content/plugins/civicrm/civicrm/CRM/Utils/System/WordPress.php on line 783
php > CRM_Utils_System::loadBootStrap([], FALSE);
php > print CRM_Core_Config::singleton()->userSystem->getTimeZoneString();
Australia/Melbourne

[eileenmcnaughton]

erm - does that show that the patch works....

[agileware-fj]

It shows that bootstrapping WordPress fixes the problems introduced in e8780288 at any rate.

[eileenmcnaughton]

@agileware-fj ok... well if you want to do a PR against the 5.14 branch I'm happy to merge to the rc

[agileware-fj]

@eileenmcnaughton alright, done – #14430

[eileenmcnaughton]

Closing as replaced by rc pr ^^