dev/core#824 Render contact type icons in std way on merge screen #13898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does 3 things 1) reduces contact get queries from 3 to 1 since the 2 in the tpl layer are removed 2) adds created date to the merge summary information 3) makes it easier for extensions to replace/ extend this data (although core makes no commitment to the tpl remaining unchanged so extension writers need to carry that risk)
The merge screen currently shows contact types as a row but that is meaningless as we don't currently permit them to be changed when merging. Rendering as an icon is more consistent with elsewhere and potentially the hover makes it easy to see salient information about the contact.
|
(Standard links)
|
|
This looks really good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Reduces clutter & increases available info & consistency by removing contact type from comparison table & putting icons next to the names
Before
After
Rendering as an icon is more consistent with elsewhere
and potentially the hover makes it easy to see salient information about the contact.
Technical Details
Note this depends on related PR #13897
Comments