Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#824 Rationalise summary part of the merge screen. #13897

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 27, 2019

Overview

This does 3 things

  1. reduces contact get queries from 3 to 1 since the 2 in the tpl layer are removed
  2. adds created date to the merge summary information
  3. makes it easier for extensions to replace/ extend this data (although core makes no
    commitment to the tpl remaining unchanged so extension writers need to carry that risk)

Before

Screenshot 2019-03-27 16 58 26

After

Created date also present - last modified date is not that useful when geocode jobs or other jobs are updating contacts - what we WOULD find useful is last donation date but I can't make a case for that as a core feature

Screenshot 2019-03-27 16 56 53

Technical Details

Comments

@civibot
Copy link

civibot bot commented Mar 27, 2019

(Standard links)

@civibot civibot bot added the master label Mar 27, 2019
This does 3 things
1) reduces contact get queries from 3 to 1 since the 2 in the tpl layer are removed
2) adds created date to the merge summary information
3) makes it easier for extensions to replace/ extend this data (although core makes no
commitment to the tpl remaining unchanged so extension writers need to carry that risk)
@eileenmcnaughton
Copy link
Contributor Author

test this please

@colemanw colemanw merged commit c8e6c43 into civicrm:master Mar 27, 2019
@colemanw colemanw deleted the merge_summary branch March 27, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants