Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TempTable methods - bookkeeping report #13847

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Code cleanup to use temp table method

Before

ad hoc method used

After

Preferred method used

Technical Details

Sub-commit of #13819 - that PR needs a lot of manual testing & since I had other reasons to test a report (trying to replicate https://lab.civicrm.org/dev/drupal/issues/50) I'm testing this report now & splitting off as reviewed & mergeable

Comments

This is a reviewer's commit - will self merge

@civibot
Copy link

civibot bot commented Mar 17, 2019

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

This works fine locally

@eileenmcnaughton eileenmcnaughton merged commit 4c86a93 into civicrm:master Mar 17, 2019
@eileenmcnaughton eileenmcnaughton deleted the report_temp branch March 17, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants