Use TempTable methods #13819
Merged
Use TempTable methods #13819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
956c644 to
df84458
Compare
e24d719 to
b451f0b
Compare
This was referenced Mar 17, 2019
|
@mfb can you rebase this? It's stale because the (slooowww) functions from the Activity BAO have now been entirely removed |
|
I tested these last 2 cases - all good. Merging |
|
\o/ we could also do some similar fixes for import. |
|
@mfb yeah - although I want some tests added to import before I touch that huckery code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use the TempTable methods to create some more temporary tables.
Before
Various classes create temporary tables via raw SQL.
After
Use CRM_Utils_SQL_TempTable methods to create temporary tables. It should no longer be necessary to cleanup temporary tables in tests as they will have unique names.