Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notices on Multisite settings form #13025

Merged
merged 1 commit into from
Oct 29, 2018

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Oct 29, 2018

Overview

Fix notices (unreleased version) on multisite settings form.

Before

e-notices
screenshot 2018-10-29 19 07 46

After

screenshot 2018-10-29 19 01 40

Technical Details

Includes #13023 & I will rebase when merged - that PR also gives more back ground.

the key thing to note here is that it proposes new things in the setting spec for html rendering

For the 'learn more' url is rendered by this in the html

    'help_link' => [
      'page' => 'Multi Site Installation',
      'resource' => 'wiki',
    ],

I also added

'entity_reference_options' => ['entity' => 'group', 'select' => array('minimumInputLength' => 0)],

Which holds the options for the entity reference field. I didn't want to use 'options' as we pretty consistently use that as an array of option values

Comments

@mattwire @seamuslee001 @colemanw

@civibot
Copy link

civibot bot commented Oct 29, 2018

(Standard links)

@seamuslee001
Copy link
Contributor

I have tested this and confirmed it fixes the e-notices and confirmed the settings are still correct.

@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001 this actually incorporates #13023 & #13022 which is the mailing components form & contribute components - did you test that too?

Also - I think it's good to get this merged ASAP as it could save people time reporting these temporary regressions -but I'm opening to tweaking the metatdata conventions introduced in this PR afterwards (& before I document them)

@seamuslee001
Copy link
Contributor

I tested the mailing components page yes

@seamuslee001
Copy link
Contributor

merging as per my review and the tag

@seamuslee001 seamuslee001 merged commit 5fe59b4 into civicrm:master Oct 29, 2018
@seamuslee001 seamuslee001 deleted the multisite_settings branch October 29, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants