Fix Contribution settings form per dev/core/473

[eileenmcnaughton]

Overview

Fix mishandling of default invoice on contribution settings form & some notices (bug not in any released version)

Before

select not populated, notices

After

above fixed

Technical Details

Stripped out a bunch of double handling in this form & commented as to where it still remains, fixed metadata

Comments

@kcristiano @seamuslee001 @mattwire

https://lab.civicrm.org/dev/core/issues/473

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

I tested this and confirmed that the default invoice setting was correctly displayed after this and saving it and re-loading was showing correct values

[seamuslee001]

(CiviCRM Review Template WORD-1.1)

• (r-explain) Pass
• (r-test) Pass
• (r-code) Pass
• (r-doc) Pass
• (r-maint) Pass
• (r-run) Pass - Settings page correct displays as per my previous comment
• (r-user) Pass
• (r-tech) Pass