CRM-21199, removed JS to hide invoice page setting #11003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---------------------------------------- * CRM-21199: Remove dependancy for 'Default invoice payment page' https://issues.civicrm.org/jira/browse/CRM-21199
|
Test build failure is unrelated |
seancolsen
approved these changes
Sep 22, 2017
There was a problem hiding this comment.
I have reviewed this PR locally on the following criteria and I think it's good to merge.
- ✅ It's a worthy pursuit.
- ✅ It works as advertised.
- ✅ It makes sense for all users who may be affected.
- ✅ It's unlikely to confuse users.
- ✅ It doesn't appear to cause bugs or unwanted side effects.
- ✅ It doesn't appear to introduce security vulnerabilities.
- ✅ New code is either: (a) not present, or (b) readable and sensible.
- ✅ Acceptance criteria are either: (a) not stated, or (b) met.
- ✅ Significant new functionality is either: (a) not present, or (b) covered by new unit tests.
- ✅ New documentation is either: (a) not needed, or (b) provided within this PR, or (c) provided in a separate PR which already exists.
|
Jenkins test this please |
|
I'm all for removing code & complexity. I'm happy the review @seanmadsen has done is appropriate to the issue, which only affects one admin screen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.civicrm.org/jira/browse/CRM-21199
Overview
Currently 'Default invoice payment page' setting under CiviContribute Settings shows up when 'Enable Deferred Revenue' is enabled. These two settings are independent of each other. We should remove the dependency on Enable Deferred Revenue since there is no logical link. People not using deferred revenue could benefit from this functionality.
Before
After