CRM-21022 - Parameterize variables in SQL query #11002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've locally tested and verified the slowness, The changes in this look right and sensible to me. I think this is ok to merge, i have been doing some testing and so far haven't been able to see any issues with it |
|
Yup works for me too. Merging now |
|
@seanmadsen would you like to QA #11003 !! |
eileenmcnaughton
pushed a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Feb 1, 2018
civicrm#11002 Change-Id: I80709653a756f88c52c5350f67467876cbb69350
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CRM-21022 for details.
Ping @seamuslee001 @eileenmcnaughton @totten @jackrabbithanna