CRM-20768 - Installer UI - Accept mysql port #10555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
== Background == In previous releases, the web-based installation script allowed you to enter the MySQL "server" with a `host:port` combination (e.g. `127.0.0.1:3307`). I believe this regressed during the mysql=>mysqli transition. == Before == If you use the web-based install UI and enter a `host:port` combination, the error messages indicate a confusing mix of information (e.g. some indicating port 3306, some indicating port 3307). == After == If you use the web-based install UI and enter a `host:port` combination, it uses the specified port. ---------------------------------------- * CRM-20768: Web-based installation should accept non-standard MySQL port https://issues.civicrm.org/jira/browse/CRM-20768
d0f22ee to
28d4c71
Compare
seamuslee001
approved these changes
Jun 25, 2017
|
@eileenmcnaughton thoughts on this? |
|
I agree @seamuslee001 - makes perfect sense & should have no impact on the currently working passing of $server with no port so seems safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Background ==
In previous releases, the web-based installation script allowed you to enter
the MySQL "server" with a
host:portcombination (e.g.127.0.0.1:3307).I believe this regressed during the mysql=>mysqli transition.
== Before ==
If you use the web-based install UI and enter a
host:portcombination, theerror messages indicate a confusing mix of information (e.g. some
indicating port 3306, some indicating port 3307).
== After ==
If you use the web-based install UI and enter a
host:portcombination, ituses the specified port.
(This is a resubmission of #10553 for 4.7.21-rc.)
https://issues.civicrm.org/jira/browse/CRM-20768