-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint-plugin-ramda #335
Changes from all commits
c3527b8
cef2d3e
3152694
361348b
ee447c3
8b9bfc1
9b1bc36
899c0d4
f922e2f
e52607f
3720c06
d2f6f9a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
import { or } from 'ramda'; | ||
|
||
|
||
const MAX_SAFE_INTEGER = or(Number.MAX_SAFE_INTEGER, (2 ** 53) - 1); | ||
const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (2 ** 53) - 1; | ||
|
||
export default MAX_SAFE_INTEGER; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
import { or } from 'ramda'; | ||
|
||
|
||
const MIN_SAFE_INTEGER = or(Number.MIN_SAFE_INTEGER, -(2 ** 53) - 1); | ||
const MIN_SAFE_INTEGER = Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would use parenthesis to explicitly state the associations of operands const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tbh I'm so used to prettier purging my files of extra parens that I it doesn't bother me. Sooner or later we'll start using it for this project and they'll be gone anyway. Not saying I disagree with you (I'v actually been complaining about its handling of parens for ages - see my comment towards the end), but using prettier is such a huge win in terms of time that it's worth the small bumps. So doesn't bother me but happy to change if you would like. |
||
|
||
export default MIN_SAFE_INTEGER; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would use parenthesis to explicitly state the associations of operands