Add eslint-plugin-ramda #335
Conversation
# Conflicts: # package.json
|
Still not working. I've flagged it on the linked issue. |
|
@char0n All passing now. Should be good to merge. |
|
Cool |
|
|
||
|
|
||
| const MAX_SAFE_INTEGER = or(Number.MAX_SAFE_INTEGER, (2 ** 53) - 1); | ||
| const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (2 ** 53) - 1; |
There was a problem hiding this comment.
Would use parenthesis to explicitly state the associations of operands
const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1)|
|
||
|
|
||
| const MIN_SAFE_INTEGER = or(Number.MIN_SAFE_INTEGER, -(2 ** 53) - 1); | ||
| const MIN_SAFE_INTEGER = Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1; |
There was a problem hiding this comment.
Would use parenthesis to explicitly state the associations of operands
const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1)There was a problem hiding this comment.
Tbh I'm so used to prettier purging my files of extra parens that I it doesn't bother me. Sooner or later we'll start using it for this project and they'll be gone anyway.
Not saying I disagree with you (I'v actually been complaining about its handling of parens for ages - see my comment towards the end), but using prettier is such a huge win in terms of time that it's worth the small bumps.
So doesn't bother me but happy to change if you would like.
|
I've created #336 for prettier integration. Wanted to try him for quite some time, this is good oportunity. Don't worry about the parents, I'll add them. |
|
@char0n WIth prettier you have to just accept that there are very few config options. That is actually the best thing about it, but if you are used to finessing how you like things to look it will be a hard at first. I honestly think it is the single biggest time-saver you can use in writing JS. So much less distraction from silly little decisions about formatting. It's very fast too. |
Code Climate have now added support for eslint-plugin-ramda.
See codeclimate/codeclimate-eslint#369 (comment)
Closes #306